Skip to content

cowork: fix packaging-quality tests on Python 3.10 (tomllib compat) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Coding-Dev-Tools wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

cowork: fix packaging-quality tests on Python 3.10 (tomllib compat) #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ dev = [
"pytest-cov>=4.0.0",
"responses>=0.24.0",
"ruff>=0.4.0",
"tomli>=2.0.0; python_version < '3.11'",
]
all = [
"hvac>=2.0.0",
Expand Down
11 changes: 7 additions & 4 deletions tests/test_cli_edge_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@

from __future__ import annotations

import sys
import yaml
try:
import tomllib # Python 3.11+
except ModuleNotFoundError: # Python 3.10
import tomli as tomllib

import sys
from pathlib import Path

import yaml
from typer.testing import CliRunner

sys.path.insert(0, str(Path(__file__).parent.parent / "src"))
Expand Down Expand Up @@ -161,7 +166,6 @@ class TestPackagingQuality:

def test_package_data_includes_py_typed(self):
"""pyproject.toml should have package-data config for py.typed."""
import tomllib

pyproject = Path(__file__).parent.parent / "pyproject.toml"
with open(pyproject, "rb") as f:
Expand All @@ -176,7 +180,6 @@ def test_package_data_includes_py_typed(self):

def test_ruff_known_first_party(self):
"""ruff known-first-party should be ['envault'], not ['*']."""
import tomllib

pyproject = Path(__file__).parent.parent / "pyproject.toml"
with open(pyproject, "rb") as f:
Expand Down
Loading