Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
========================================
Coverage 96.90% 96.91%
========================================
Files 1095 1099 +4
Lines 145109 145449 +340
========================================
+ Hits 140621 140965 +344
+ Misses 4488 4484 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isPANN
marked this pull request as draft
October 17, 2026 11:15
isPANN
marked this pull request as ready for review
October 17, 2026 16:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registered numeric variants were missing direct conversions, forcing path search through unrelated models or leaving variants disconnected. Add 20 missing edges: 15
One → i64conversions (including three decision wrappers) and fivei64 → f64conversions. All 29 matching numeric variant pairs now have direct executable edges.Reuse the existing variant-reduction macro and declare exact identity parameter transforms. Unit-weight conversions preserve witnesses, objective values, and decision thresholds. The five new float conversions reject coefficients or accumulated objective bounds outside the exact-integer float range; Steiner forest also checks its scaled costs. No new variants or dependencies are introduced. Existing ILP rules qualify their shared trait helpers where the additional implementations would otherwise make type inference ambiguous.
Add a registry-wide test that discovers matching weight/coefficient variants automatically and requires direct witness-executable conversions. Behavior tests compare complete converted instances against independently deserialized target instances, solve both sides with the real brute-force solver, recover source optima and aggregate values, and exercise precision and overflow boundaries. Two unit-weight model examples supply inputs for the existing executable parameter-formula checks.
Remove Typst explanations of pure numeric casts, including the existing Spin Glass, Set Packing, and QUBO entries and numeric-cast paragraphs in MIS and ILP. Keep graph transformations, fixed-to-generic variants, and bounded-integer encodings. The paper completeness filter excludes only numeric promotions that leave every other variant dimension unchanged; a build-time assertion checks that a graph-changing MIS rule remains nontrivial. Repository guidance records this distinction.
Validation:
make paperpassed, including the numeric/nontrivial classification assertions.make checkstill ends at the existingproblemreductions-macros/src/lib.rs:211doctest failure: its standalone reduction attribute has no attached item. That file is unchanged frommain.