fix(embedding-linker) optimizer, transformer config, and naming fixes#416
Merged
adam-sutton-1992 merged 13 commits intomainfrom Apr 24, 2026
Merged
fix(embedding-linker) optimizer, transformer config, and naming fixes#416adam-sutton-1992 merged 13 commits intomainfrom
adam-sutton-1992 merged 13 commits intomainfrom
Conversation
This PR should make the workflow actually run upon changes.
mart-r
approved these changes
Apr 24, 2026
Collaborator
mart-r
left a comment
There was a problem hiding this comment.
The logged comment looks odd in serialise_to - what it's describing doesn't seem to be happening.
Other than that, looks good.
Contributor
Author
|
Fixed that doc issue - from the old embedding linker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hihi,
Three fixes/changes in here for the most part.
reset_optimizer_and_scalerwhich points the optimzer to the right model. I also expose learning rate and weight decay, so they're config settings that can be set and changed here.nametotrainable_embedding_linkerand the class name to Linker. To be consistent with previous design. This was an issue with creating new components and deserializing.