Skip to content

feat(medcat-den): Make credentials optional for remote dens #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alhendrickson merged 1 commit into from
Apr 24, 2026
+2 −4
Merged

feat(medcat-den): Make credentials optional for remote dens #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions medcat-den/src/medcat_den/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Union
from typing import Union, Optional
from pathlib import Path

from pydantic import BaseModel
Expand All @@ -16,7 +16,7 @@ class LocalDenConfig(DenConfig):

class RemoteDenConfig(DenConfig):
host: str
credentials: dict
credentials: Optional[dict] = None
allow_local_fine_tune: bool
allow_push_fine_tuned: bool

Expand Down
2 changes: 0 additions & 2 deletions medcat-den/src/medcat_den/resolver/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ def _init_den_cnf(
host = host or os.getenv(MEDCAT_DEN_REMOTE_HOST)
if not host:
raise ValueError("Need to specify a host for remote den")
if not credentials:
raise ValueError("Need to specify credentials for remote den")
# NOTE: these will default to False when nothing is specified
# because "None" is not in ALLOW_OPTION_LOWERCASE
allow_local_fine_tune = str(
Expand Down
Loading