Skip to content

fix(embedding_linker)fixing the comp name requirement #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mart-r merged 3 commits into from
Apr 24, 2026
Merged

fix(embedding_linker)fixing the comp name requirement #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75f6ff7
fixing the comp name requirement
adam-sutton-1992 Apr 24, 2026
bb820da
Merge branch 'main' into comp_name-fix
github-actions[bot] Apr 24, 2026
98450bc
fixes to testing
adam-sutton-1992 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion medcat-plugins/embedding-linker/src/medcat_embedding_linker/embedding_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ def _pre_inference(
def predict_entities(
self, doc: MutableDocument, ents: list[MutableEntity] | None = None
) -> list[MutableEntity]:
if self.cnf_l.train and self.comp_name == "embedding_linker":
if self.cnf_l.train and self.name == "embedding_linker":
logger.warning(
"Attemping to train a static embedding linker. "
"This is not possible / required."
Expand Down
4 changes: 2 additions & 2 deletions medcat-plugins/embedding-linker/tests/test_embedding_linker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ class TrainableEmbeddingLinkerTests(unittest.TestCase):
cnf = Config()
cnf.components.linking = embedding_linker.EmbeddingLinking()
cnf.components.linking.comp_name = (
trainable_embedding_linker.TrainableEmbeddingLinker.name
trainable_embedding_linker.Linker.name
)
linker = trainable_embedding_linker.TrainableEmbeddingLinker(FakeCDB(cnf), cnf)
linker = trainable_embedding_linker.Linker(FakeCDB(cnf), cnf)

def test_linker_is_trainable(self):
self.assertIsInstance(self.linker, TrainableComponent)
Expand Down
Loading