fix: remove erroneous cents-to-dollars conversion in notification email renderer#76
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…derer NotificationRenderer.FormatCurrency() incorrectly divided TotalAmount by 100, assuming it was in cents. The OrderPlacedEvent.TotalAmount is already in dollars (decimal), so dividing by 100 turned $149.99 into $1.50. Removed the division. Also fixes Notification.API.csproj Shared project references (../../ → ../../../) so the service actually builds.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause:
NotificationRenderer.FormatCurrency()dividedamountby 100, assumingOrderPlacedEvent.TotalAmountwas in cents. It is actually already in dollars (decimal), so149.99 / 100 = 1.4999→ displayed as$1.50.private static string FormatCurrency(decimal amount) { - var dollars = amount / 100m; - return dollars.ToString("C2"); + return amount.ToString("C2"); }Also fixes
Notification.API.csproj— theSharedproject references used../../Shared/...(two levels up) instead of../../../Shared/...(three levels up fromServices/Notification/Notification.API/), which prevented the service from building.Before / After
Reproduced by POSTing
{"totalAmount": 149.99}to/api/notification/events/order-placedand checking the/previewendpoint.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/ee5f8a81c78f4994b32fd0b8cd6f306a
Requested by: @bsmitches