Migrate src/app/pages/ui/ module from AngularJS to React#89
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Migrate src/app/pages/ui/ module from AngularJS to React#89devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Create 11 React page components (Typography, Buttons, Icons, Modals, Grid, Alerts, ProgressBars, Notifications, Tabs, Slider, Panels) - Add react2angular bridge directives via uiReact.js - Update all UI sub-module routes to use React bridge templates - Export all components from react/index.jsx - Configure gulp serve/inject/build for React bundle - Add React 18 CDN scripts and bundle.js to index.html - All 65 E2E tests passing
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Track the setTimeout handle via timerRef and clear it in the useEffect cleanup to prevent stale onClose calls after unmount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all 11 UI sub-modules (typography, buttons, icons, modals, grid, alerts, progressBars, notifications, tabs, slider, panels) from AngularJS controllers/templates to React components using the existing react2angular bridge pattern.
Each AngularJS controller+template pair → single React component in
src/app/react/pages/, usingReact.createElement(),useState/useCallback/useRef/useEffecthooks, and the sharedPanelcomponent. jQuery plugins (ionRangeSlider, bootstrapSwitch) initialized viauseEffect(fn, [])with cleanup. Custom modal overlay manages backdrop DOM directly.Bridge wiring:
src/app/pages/ui/uiReact.jscreates 11 directives viacreateBridgeDirective()loop → each callswindow.BlurAdminReact.mountReactApp(Component, element[0], {}). All 11*.module.jsroute files updated: removedabstract: true, child states,$urlRouterProviderredirects; replacedtemplateUrl+controllerwithtemplate: '<directive-react></directive-react>'.Gulp config:
server.jsservesbuild/react/,inject.jsexcludessrc/app/react/**,build.jsaddscopyReactBundletask.index.htmlloads React 18 CDN +bundle.js.All 65 E2E tests pass.
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/293e6a97d83a429c826418b137c4c127
Requested by: @DhrovS