Milestone 1: Branch setup + REVIEW.md with upgrade checkpoint definitions#143
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Milestone 1: Branch setup + REVIEW.md with upgrade checkpoint definitions#143devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Also adds AGENTS.md and .devin/skills/ to guide future Devin sessions through the incremental Java 25 upgrade milestones.
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Address Devin Review feedback — the scope description now explicitly notes that javax.crypto stays as-is, consistent with the review criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates the long-lived
java-25-targetbranch and establishes the roadmap for incrementally upgrading from Java 11 + Spring Boot 2.6.3 to Java 25 + Spring Boot 3.5+.Files added:
REVIEW.md— Defines 10 milestones with explicit scope, affected files, and review-criteria checklists for each step of the upgrade (Spring Boot 2.7, Joda-Time removal, javax to jakarta, Spring Boot 3 + Java 17, dependency bumps, JJWT migration, Java 25, modern idioms, final audit).AGENTS.md— Agent guidelines for future Devin sessions: branch strategy, milestone execution rules, verification commands, architecture overview, dependency notes, and common pitfalls..devin/skills/java25-upgrade-milestone.md— Reusable step-by-step skill for executing any single milestone (read spec, branch, implement, verify, PR).No functional code changes. This is purely planning and scaffolding for the upgrade work ahead.
Follow-up fix: Clarified Milestone 4 scope to explicitly exclude
javax.cryptofrom the jakarta migration (it's injava.base, not Jakarta EE), resolving a contradiction between the scope description and review criteria.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/788cb040e148433782ecbf169178c389
Requested by: @bsmitches