forked from gothinkster/spring-boot-realworld-example-app
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade to Java 21 + Spring Boot 3.5 (javax→jakarta, Security 6, DGS/MyBatis majors) #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
20
commits into
main
Choose a base branch
from
migration/java-21-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
757a5c7
Bump Spotless to 6.25.0 and JaCoCo to 0.8.12
devin-ai-integration[bot] 72ff82b
Bump org.xerial:sqlite-jdbc from 3.36.0.3 to 3.46.0.0
devin-ai-integration[bot] 19a5bb3
Merge pull request #166 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] ba317b3
Merge pull request #167 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] 839ad0e
Replace org.joda.time.DateTime with java.time.Instant
devin-ai-integration[bot] dbbc38a
Merge pull request #168 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] b194b2c
Upgrade JJWT from 0.11.2 to 0.12.6
devin-ai-integration[bot] 9782eba
Merge pull request #169 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] 34f2eb2
Upgrade Gradle wrapper from 7.4 to 8.10.2
devin-ai-integration[bot] 9fef47b
Merge pull request #172 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] da35245
Phase 2: Spring Boot 3.5 + Java 21 (jakarta, SecurityFilterChain, Gra…
devin-ai-integration[bot] a7deb41
Merge PR #173: Spring Boot 3.5 + Java 21 big bang; reconcile with bas…
devin-ai-integration[bot] 600b571
Phase 3: modernize Selenium 4 E2E deps + migrate @MockBean to @Mockit…
devin-ai-integration[bot] 6021710
Merge PR #174: Phase 3 - modernize Selenium 4 E2E suite + @MockBean->…
devin-ai-integration[bot] c36953e
feat: upgrade to Spring Boot 3.5.0 and Java 21
devin-ai-integration[bot] ddb09f8
Merge pull request #176 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] c0c2216
docs: document Phase 3c classpath verification — no javax conflicts f…
devin-ai-integration[bot] 3864547
chore: bump Selenium, WebDriverManager, TestNG, and ExtentReports tes…
devin-ai-integration[bot] 62fad80
Merge pull request #177 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] 3ff7b92
Merge pull request #178 from Cognition-Partner-Workshops/migration/ph…
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 11 | ||
| 21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Flyway SQLite support may require additional dependency with Spring Boot 3.5
Spring Boot 3.5.0 ships with Flyway 10+ which modularized database-specific support into separate artifacts. The build only declares
implementation 'org.flywaydb:flyway-core'atbuild.gradle:65. If the bundled Flyway version requiresorg.flywaydb:flyway-database-sqlitefor SQLite support, the application would fail at startup. This depends on the exact Flyway version managed by the Spring Boot 3.5.0 BOM — if it's Flyway 10+, SQLite support was moved out of core. This should be verified by running the application or tests against the SQLite database.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified — this does not apply to this project's usage. The Boot 3.5 BOM resolves
flyway-coreto 11.7.2 (noflyway-database-sqliteon the classpath), and SQLite migrations still run successfully:RealworldApplicationTests.contextLoadsis@SpringBootTestwith the default profile, so it usesspring.datasource.url=jdbc:sqlite:dev.db(file-based) and boots the full context — which triggers Flyway auto-configuration to applyV1__create_tables.sql+V2__seed_data.sqlat startup. That test passes (tests="1" failures="0" errors="0"), exercising the exact app-startup migration path you flagged.DbTestBase→@MybatisTest,@ActiveProfiles("test"), in-memoryjdbc:sqlite::memory:,spring.flyway.target=1) also apply V1 via Flyway and pass (e.g.ArticleRepositoryTransactionTest,MyBatisArticleRepositoryTest).So Flyway 11 handles SQLite here without the separate module, and the green
@SpringBootTestcontext-load test will catch any regression if the managed Flyway version ever drops bundled SQLite support. No change needed.