Skip to content

P1 follow-up: fix m2e gmavenplus goal names and javadoc doclint#6

Open
devin-ai-integration[bot] wants to merge 1 commit into
migration/java-21-migrationfrom
devin/p1-review-followups
Open

P1 follow-up: fix m2e gmavenplus goal names and javadoc doclint#6
devin-ai-integration[bot] wants to merge 1 commit into
migration/java-21-migrationfrom
devin/p1-review-followups

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 17, 2026

Copy link
Copy Markdown

Summary

Follow-up to the merged P1 build/plugin upgrade (#5), addressing two in-scope build-config items raised by automated review. Part of the automated Broadleaf Commerce Java 21 migration. Scoped to root pom.xml only; no source/Spring/Hibernate/javaxjakarta work.

Both changes verified on JDK 21: mvn -N help:effective-pom -Pblc-development,javadocs and mvn validate -Pblc-development both succeed.

Changes

  • Eclipse m2e lifecycle-mapping goal names. The gmavenplus execution goals were renamed to the 3.x names in P1: Upgrade Maven build/plugin layer to Java 21 #5 (testCompilecompileTests, testGenerateStubsgenerateTestStubs), but the m2e lifecycle-mapping filter still listed the old names, so the renamed goals would no longer be matched by the IDE ignore filter (Eclipse "Plugin execution not covered by lifecycle configuration"). Updated the filter goal list to the 3.x names. Editor-only config; no effect on the Maven CLI build.
  • javadoc doclint. maven-javadoc-plugin was bumped to 3.7.0 in P1: Upgrade Maven build/plugin layer to Java 21 #5, which ignores the deprecated <additionalparam>-Xdoclint:none</additionalparam> property used by the disable-java8-doclint profile — so doclint would no longer actually be disabled under JDK 21 in the (opt-in) javadocs profile. Added <doclint>none</doclint> to the maven-javadoc-plugin configuration, the 3.x-supported equivalent.

Review items intentionally not addressed here (out of P1 scope)

  • Spock 1.0-groovy-2.3 incompatibility with Groovy 4 and the spock-spring org.codehaus.groovy exclusion belong to the Spock/Groovy test-migration phase (Spock 1.0 still resolves the old groupId today, so the exclusion is correct as-is).
  • Spring 4.1 / Hibernate 4.1 runtime compatibility with JDK 21 belongs to the framework-upgrade phase.

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/e6da6fecd09545e19497677ea1fa54f4
Requested by: @mbatchelor81


Open in Devin Review

- Update Eclipse m2e lifecycle-mapping gmavenplus goals to 3.x names (testCompile->compileTests, testGenerateStubs->generateTestStubs) to match the execution block.
- maven-javadoc-plugin 3.x ignores the deprecated additionalparam property; add <doclint>none</doclint> to the javadocs profile plugin config so doclint is actually disabled.
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant