P1 follow-up: fix m2e gmavenplus goal names and javadoc doclint#6
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
P1 follow-up: fix m2e gmavenplus goal names and javadoc doclint#6devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Update Eclipse m2e lifecycle-mapping gmavenplus goals to 3.x names (testCompile->compileTests, testGenerateStubs->generateTestStubs) to match the execution block. - maven-javadoc-plugin 3.x ignores the deprecated additionalparam property; add <doclint>none</doclint> to the javadocs profile plugin config so doclint is actually disabled.
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the merged P1 build/plugin upgrade (#5), addressing two in-scope build-config items raised by automated review. Part of the automated Broadleaf Commerce Java 21 migration. Scoped to root
pom.xmlonly; no source/Spring/Hibernate/javax→jakartawork.Both changes verified on JDK 21:
mvn -N help:effective-pom -Pblc-development,javadocsandmvn validate -Pblc-developmentboth succeed.Changes
testCompile→compileTests,testGenerateStubs→generateTestStubs), but the m2elifecycle-mappingfilter still listed the old names, so the renamed goals would no longer be matched by the IDE ignore filter (Eclipse "Plugin execution not covered by lifecycle configuration"). Updated the filter goal list to the 3.x names. Editor-only config; no effect on the Maven CLI build.maven-javadoc-pluginwas bumped to 3.7.0 in P1: Upgrade Maven build/plugin layer to Java 21 #5, which ignores the deprecated<additionalparam>-Xdoclint:none</additionalparam>property used by thedisable-java8-doclintprofile — so doclint would no longer actually be disabled under JDK 21 in the (opt-in)javadocsprofile. Added<doclint>none</doclint>to themaven-javadoc-pluginconfiguration, the 3.x-supported equivalent.Review items intentionally not addressed here (out of P1 scope)
1.0-groovy-2.3incompatibility with Groovy 4 and thespock-springorg.codehaus.groovyexclusion belong to the Spock/Groovy test-migration phase (Spock 1.0 still resolves the old groupId today, so the exclusion is correct as-is).Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/e6da6fecd09545e19497677ea1fa54f4
Requested by: @mbatchelor81