Open
Conversation
todo completed
Tamir198
requested changes
Dec 16, 2025
| export default function ShowCard( | ||
| /* TODO 1: Accept props with ShowCardProps type here */ | ||
| ) { | ||
| export default function ShowCard(props: ShowCardProps) { |
| export default function ShowCard(props: ShowCardProps) { | ||
| // TODO 2: Create state called isInterested of type boolean (default false) | ||
| // const [isInterested, setIsInterested] = ... | ||
| const [isInterested, setIsInterested] = useState<boolean>(false); |
Member
There was a problem hiding this comment.
Do you really need the generic in here?
Author
There was a problem hiding this comment.
got it so, in what scenarios would you recommend explicitly defining the generic vs. letting inference handle it?
| // >30 → "Tickets available" | ||
|
|
||
| let ticketsStatusText = ""; | ||
| if (props.ticketsLeft === 0) { |
Member
There was a problem hiding this comment.
Save all of your numbers inside constant variables
|
|
||
| let ticketsStatusText = ""; | ||
| if (props.ticketsLeft === 0) { | ||
| ticketsStatusText = "SOLD OUT"; |
Member
There was a problem hiding this comment.
ALL of the strings should come from constant file
| <div className="shows-grid"> | ||
| {/* TODO - shows.map((show)=>{ return <ShowCard id={show.id} .../> })*/} | ||
| {shows.map((show) =>{ return ( | ||
| <ShowCard id={show.id} artist={show.artist} stage={show.stage} day={show.day} hour={show.hour} ticketsLeft={show.ticketsLeft} image={show.image} /> |
Member
There was a problem hiding this comment.
You can also :
{shows.map((show) => (
<ShowCard key={show.id} {...show} />
))}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.