Add LC/MS visualization support for OpenLab and Chemstation data#289
Draft
Nicolass67 wants to merge 42 commits intomasterfrom
Draft
Add LC/MS visualization support for OpenLab and Chemstation data#289Nicolass67 wants to merge 42 commits intomasterfrom
Nicolass67 wants to merge 42 commits intomasterfrom
Conversation
…proved entity handling
… improved integration display
…nents; update format.js for improved HPLC UV/VIS output
… LineFocus component
Update failing unit tests to match the current getArea input shape, extractPeaksEdit LCMS signature, and reducer default empty-curve behavior. Made-with: Cursor
…Focus components; add store reference to window object
… TIC selection handling in d3_line_rect component
…andling in Threshold component
Made-with: Cursor
Nicolass67
force-pushed
the
231-display-lcms-data
branch
from
df63c41 to
c8567d5
Compare
…y and clarity; enhance parsing and extraction logic
…ance unit definitions and streamline data handling
…do/redo functionality for UVVIS edits, streamline data export options, and improve layout management (sylvia feedbacks)
… add loading indicators and improve state management for MS features
… up code and improve performance
…elength selection, improve MS page request logic, and streamline parsing for better performance and clarity
…ew versions and resolve integrity issues
… request logic in componentDidUpdate and streamline Cypress tests for request validation
… cover normalization, inference, and data structure handling for peaks and integrals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces LC/MS visualization support in Spectra Editor.
We now support two LC/MS sources:
What users can do in LC/MS
In LC/MS layouts, users can now:
Open and visualize OpenLab and Chemstation LC/MS datasets.
Work across the 3 synchronized views:
Switch TIC polarity (PLUS / MINUS / NEUTRAL when available).
Switch UV/Vis wavelength and update the active spectrum context.
Use zoom and zoom reset reliably.
Add/edit interactions in LC/MS workflows (peaks and integration actions) across UV-VIS wavelength.
Change the displayed MS spectrum via Peak group select: click on the TIC (Total Ion Chromatogram) to select a retention time; the MS view updates to show the mass spectrum at that time.
Tests
Unit tests
E2E tests
Extended Cypress coverage in cypress/e2e/lcms_spec.cy.ts, including: