MS: hover labels use toolbar decimal setting#296
Open
Nicolass67 wants to merge 1 commit intomasterfrom
Open
Conversation
Pass submit.decimal into RectFocus; compass and d3-tip use it for m/z precision on MS layout only. Add clampDecimalPlaces helper. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the mismatch where MS hover always showed three decimal places while the toolbar “Decimal” control allowed 0–4.
Changes
Pass submit.decimal from Redux into the MS rect viewer (RectFocus).
Compass cursor label: for MS only, format m/z with the same decimal count as the toolbar (other layouts unchanged).
Peak tooltip on MS bars: optional xDigits so x in the tip matches that setting; add Format.clampDecimalPlaces for safe parsing.
Closes #3026