test: pin set_widget LWW gate op_id/actor tiebreaks in both arrival orders (follow-up to #161) - #176
Open
christian-byrne wants to merge 1 commit into
Open
christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
…rders Follow-up to #161 (approve-with-comments by benceruleanlu): the op_id tiebreak case only covered the forward arrival order, so the file stayed green under a gate that compares only the counter. Adds the reverse op_id arrival order and an equal-counter/different-actor case in both arrival orders (KA-2, FC-2, FC-7). Verified both new tests fail against a counter-only gate mutation while the original four pass.
|
Warning Review limit reachedNext included review available in 36 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 129 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #161, addressing the single review item from the approve-with-comments review by benceruleanlu:
(Quoted from the review body; no @-mention per quiet-week contact rules.)
Test-only change. No production behavior or outcome strings change.
What changed
op_idarrival order: applies the lowerop_idfirst at an equal counter+actor, then the higher one, which must beapplied— this kills the "compares only the counter" mutation that the original forward-order test survives.agent:bbeatsagent:aat the same counter regardless of arrival order, converging on the same stamp and projected document (KA-2, FC-2, FC-7).Evidence
npm test -- test/set-widget-lww-gate.test.ts— 6 passed (4 pre-existing + 2 new)compareStampKeysto counter-only — the 4 original tests still pass but both new tests fail, confirming the file now kills that mutation on its own; mutation revertednpm test— 969 passed, 8 failed intest/check-import-graph.test.ts; reproduced identically on pristine main (8 failed / 2 passed with this change stashed), so pre-existing and unrelated to this PRnpm run typecheck— passednpm run lint— 0 errors (1662 existing warnings)