Skip to content

test: recover batch result helper contract - #202

Draft
christian-byrne wants to merge 2 commits into
mainfrom
christian-byrne/cmprec-23-results
Draft

christian-byrne wants to merge 2 commits into
mainfrom
christian-byrne/cmprec-23-results

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Recover batch-result docs and helpers.
  • No production behavior changes.
  • Draft; fresh review still required.

Human owner: christian-byrne

Full context for agent readers

Recovery scope

Recovers result-contract portions of the preserved frontend migration parent, directly onto standalone comfy-multi-player main. Frontend relocation remains deferred. The private parent map identifies these portions as H013, H014 and H063 through H065 (source hunk identifiers).

Retry documentation now names duplicate outcomes as no-op and lists batch_aborted. Applier tests reuse shared helpers without dropping assertions. The shared rejectedOutcome skips unprocessed aborted suffixes and returns the substantive rejection. The distinct indexed helper remains untouched.

Verification

Node 22.22.2; byte-identical lockfile dependencies reused without installation. Complete types/build and package gates passed: purity, imports, pins, profile claims, generated reviewer configuration and corpus verification. Full suite: 991 passed. Focused helper and applier suites: 135 passed. Two focused helper tests failed before implementation; all three passed afterward. Hosted checks and fresh review remain pending; mutation testing was not run.

Review continuity and invariants

None of the migration parent's 25 captured unresolved root comments is satisfied merely by this slice. Their original authors, dates, anchors and links remain in the preserved collaboration ledger for individual reconciliation. No historical approval or QA result becomes current sign-off. Other parent type/schema work remains separate.

No production source, operation semantics, public exports, dependencies or widget catalog changed. A substantive rejection is the operation that failed; batch_aborted identifies an operation never processed because of an earlier rejection. Original PRs and source branches remain intact.

@christian-byrne christian-byrne self-assigned this Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R1 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant