test: recover batch result helper contract - #202
Draft
christian-byrne wants to merge 2 commits into
Draft
christian-byrne wants to merge 2 commits into
christian-byrne wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human owner: christian-byrne
Full context for agent readers
Recovery scope
Recovers result-contract portions of the preserved frontend migration parent, directly onto standalone comfy-multi-player main. Frontend relocation remains deferred. The private parent map identifies these portions as H013, H014 and H063 through H065 (source hunk identifiers).
Retry documentation now names duplicate outcomes as
no-opand listsbatch_aborted. Applier tests reuse shared helpers without dropping assertions. The sharedrejectedOutcomeskips unprocessed aborted suffixes and returns the substantive rejection. The distinct indexed helper remains untouched.Verification
Node 22.22.2; byte-identical lockfile dependencies reused without installation. Complete types/build and package gates passed: purity, imports, pins, profile claims, generated reviewer configuration and corpus verification. Full suite: 991 passed. Focused helper and applier suites: 135 passed. Two focused helper tests failed before implementation; all three passed afterward. Hosted checks and fresh review remain pending; mutation testing was not run.
Review continuity and invariants
None of the migration parent's 25 captured unresolved root comments is satisfied merely by this slice. Their original authors, dates, anchors and links remain in the preserved collaboration ledger for individual reconciliation. No historical approval or QA result becomes current sign-off. Other parent type/schema work remains separate.
No production source, operation semantics, public exports, dependencies or widget catalog changed. A substantive rejection is the operation that failed;
batch_abortedidentifies an operation never processed because of an earlier rejection. Original PRs and source branches remain intact.