This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Conversation
|
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Contributor
|
Can you make sure that the Xaml Islands repo still builds and that MSIX can still be compiled and run after this change? |
Member
|
@azchohfi is there anything left before we merge this? |
Contributor
Author
|
Do not merge! This was not working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No symbols at all for the Microsoft.Toolkit.Win32.UI.XamlApplication package.
What is the new behavior?
Stripped and added symbols for the Microsoft.Toolkit.Win32.UI.XamlApplication package.
PR Checklist
Please check if your PR fulfills the following requirements: