Fix #215 - Extra webview2 dll in nuget package

[michael-hawker]

Remove webview2loader.dll from package (hopefully) - test workaround to report back to platform.

Fixes #215

Going to open a Windows PR using this to see if it resolves the issue or not.

[Arlodotexe]

Reposting CommunityToolkit/Windows#521 (comment)

I've managed to fix the issue. It took a combination of updating WebView2 (as per @Sergio0694's suggestion) and removing both conditions around WebView2NeverCopyLoaderDllToOutputDirectory. Leaving either condition would result in broken packages again, but with both removed and webview2 updated:

This seems to have also resolved the issue with the extra net8.0-windows10.0.22621.0 TFM being included alongside net8.0-windows10.0.22621.

[beeradmoore]

@Arlodotexe , I was previously using CommunityToolkit.Labs.WinUI.MarkdownTextBlock, but all of a sudden I am having a bunch of issues about copying the webview 2 dll. Going down the rabbit hole led me here.

From what I can understand we are waiting for things to be merged and pushed to labs preview feed?

Is there any way to fix this in our application in the meantime? I have tried adding WebView2 nuget, as well as differnet combinations of with/without/with different values of WebView2NeverCopyLoaderDllToOutputDirectory but nothing seems to fix it.

EDIT: A workaround I have found now is to copy CommunityToolkit.WinUI.Controls.MarkdownTextBlock from net8.0-windows10.0.22621.0 to the net8.0-windows10.0.22621 folder

[michael-hawker]

@beeradmoore this should be fixed in the latest labs packages, as the tooling PR was updated in Labs here: CommunityToolkit/Labs-Windows#574

FYI @Arlodotexe

[beeradmoore]

Hey @michael-hawker , confirming this appears to be fixed.

I nuked my nuget packages cache and updated to 0.1.241029-build.1770 and it now builds fine. Formatting is still way off when showing markdown compared to where it came from pre-labs, but at least the project builds now without workarounds.

[michael-hawker]

Thanks for confirming @beeradmoore! 🦙❤️ Yeah, there's definitely still a gap from where the old control was to this new one. The big advantage here to the new one is that it's no longer built on a bespoke custom-built parser underneath.

Feel free to submit any fixes you find for anything, happy to take contributions!