Conversation
- For MyCompassion2, the order of the attachments need to be reversed
* T2624 Add callbacks for pdf generation * T2288 Force-the-maximum-pages-of-a-letter-to-be-15 (#2051) * Reapply "Add page nb check" This reverts commit 8d4d27f. * Run precommit * Add args safety to callbacks Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Remove redundant error raised --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Remove callbacks * Code improvements * Fix concurency cohenrence * Fix error propagation when more than 15 pages * Run precommit --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Emanuel Cino <ecino@compassion.ch>
Remove unecessary update_nb_sposorships Refactor names and run precommit
…-it-should-be-one-is-an-isolated-case' into 14.0-MyCompassion2
* Fix sytax error. * Refactor and ensure atomiity of transaction * Fix concurrency problem * Refactor and add comments * Remove typos * Update sbc_compassion/models/correspondence_s2b_generator.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update sbc_compassion/models/correspondence_s2b_generator.py Fix sytax error. Refactor and ensure atomiity of transaction Fix concurrency problem Refactor and add comments Remove typos Co-Authored-By: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Remove unecessary cursors creation * Refactor * Rollback changes * Define isaolated_write and refactor * Reorder the DONE status update * Allow updating the generation status from the back end --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
# Conflicts: # sbc_compassion/models/correspondence_s2b_generator.py # sponsorship_compassion/models/res_partner.py
* Restirct notif. to only hold of type SUB_CHILD_HOLD * Run precommit * Correct wrong type of Hold * Fix typo
Summary of ChangesHello @avuff, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project suspension communication system by automating the notification process for sponsors and streamlining the underlying communication templates. It also brings crucial improvements to the stability and user feedback of the PDF generation utility, making the system more reliable and user-friendly. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces new suspension communication rules, including a cron job to manage project suspension announcements and follow-ups. It also significantly enhances the robustness and user feedback for the S2B (Sponsor-to-Beneficiary) letter generation process by adding detailed status tracking, improved error handling, and better resource management for temporary files. Obsolete communication configurations and email templates have been removed, and a migration script is provided to clean up old data.
| <record id="ir_cron_suspension_announcement" model="ir.cron"> | ||
| <field | ||
| name="name" | ||
| >Project: 2-Month Suspension Annoucement/Follow-Up</field> |
There was a problem hiding this comment.
There is a typo in the cron job's name. "Annoucement" should be "Announcement".
| >Project: 2-Month Suspension Annoucement/Follow-Up</field> | |
| >Project: 2-Month Suspension Announcement/Follow-Up</field> |
4 participants
No description provided.