T2346 cannot search for more than 2 children in global childpool

[avuff]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @avuff, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the global child search functionality, enabling the retrieval of more than two children. It also significantly enhances the letter generation system by adding real-time status updates, enforcing a page limit, and improving error handling. Furthermore, the PR introduces a new categorization feature for communication snippets and refines the notification process for child holds, leading to more accurate and informative user feedback.

Highlights

• Bug Fix: Global Child Search: Corrected an issue in the global child search wizard that prevented it from retrieving more than two children by adjusting the 'skip' offset calculation to use self.take instead of self.nb_selected.
• Enhanced Letter Generation with Status Tracking: Introduced real-time status tracking (generation_status, generation_error_message) for the letter generation process, implemented a maximum page limit (15 pages) for generated letters, and improved error handling with transaction rollbacks and better temporary file management during PDF creation. Sponsor's preferred name is now prioritized in letter content.
• Communication Snippet Categorization: Added new functionality to categorize communication snippets by introducing a CommunicationSnippetCategory model and associated category_id and description fields to the CommunicationSnippet model, along with corresponding UI updates and access rights.
• Refined Hold Notification Logic: Refactored the notification logic for 'no money holds' to ensure messages are posted more precisely, specifically checking for the existence of a sponsorship before sending extension notifications and providing appropriate messages when no sponsorship is found.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily fixes an issue with pagination in the global child search, ensuring correct retrieval of subsequent result pages. Additionally, it introduces significant enhancements to the PDF generation process, including robust error handling, detailed status tracking for background jobs, and improved resource management to prevent leaks. I've included one comment to improve code readability. The changes are well-implemented and improve the overall quality of the codebase.

[gemini-code-assist]

The nested ternary operator for assigning error_message is a bit complex and can be hard to read. Refactoring this into a standard if/elif/else structure would improve code clarity and maintainability.

            if isinstance(error, PolicyError):
                error_message = _(
                    "Unfortunately the server cannot generate PDF documents "
                    "at the moment. Our IT team is informed and will fix this issue "
                    "as soon as possible."
                )
            elif isinstance(error, UserError):
                error_message = str(error)
            else:
                error_message = _(
                    "There was an error while generating the PDF of the letter. "
                    "Please check FPDF logs for more information."
                )