Add step to build a "production" fedora build on pull requests - #15090
Add step to build a "production" fedora build on pull requests#15090Mab879 wants to merge 1 commit into
Conversation
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
bea3ac0 to
f2d43ca
Compare
df65829 to
fd7dcc8
Compare
To catch issues with packaging
fd7dcc8 to
4ac1fb8
Compare
| Version: 0.1.82 | ||
| Release: 1%{?dist} |
There was a problem hiding this comment.
I think it will build the version 0.1.82 forever.
In the other spec file, we have this:
# Version placeholder. Copr build version is determined by utils/version.sh. See .packit.yaml config
Version: 0.0.1
Release: 0%{?dist}
Try to have this thing also in this spec file.
|
/packit build |
|
Just an FYI will have to switch up the names for the required builds due to this PR. |
| %define cmake_defines_common -DSSG_SEPARATE_SCAP_FILES_ENABLED=OFF -DSSG_BASH_SCRIPTS_ENABLED=OFF -DSSG_BUILD_SCAP_12_DS=OFF | ||
| %define cmake_defines_specific %{nil} | ||
| %if 0%{?rhel} && ! %{defined eln} | ||
| %define cmake_defines_specific -DSSG_PRODUCT_DEFAULT:BOOLEAN=FALSE -DSSG_PRODUCT_RHEL%{rhel}:BOOLEAN=TRUE -DSSG_SCIENTIFIC_LINUX_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_CENTOS_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_ANSIBLE_PLAYBOOKS_PER_RULE_ENABLED:BOOL=ON |
There was a problem hiding this comment.
This seems to be yielding -DSSG_PRODUCT_RHEL46:BOOL=ON
%{rhel} is being set to 46 here according to: https://artifacts.dev.testing-farm.io/9c3be016-7b69-4e04-a739-6e5026e36de3/work-cixgdpip_f/plans/ci/execute/data/guest/default-0/static-checks/rpmbuild-ctest-1/output.txt
We probably need to hardcode the RHEL version here, or build all the products instead
| %define cmake_defines_specific -DSSG_PRODUCT_DEFAULT:BOOLEAN=FALSE -DSSG_PRODUCT_RHEL%{rhel}:BOOLEAN=TRUE -DSSG_SCIENTIFIC_LINUX_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_CENTOS_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_ANSIBLE_PLAYBOOKS_PER_RULE_ENABLED:BOOL=ON | |
| %define cmake_defines_specific -DSSG_PRODUCT_DEFAULT:BOOLEAN=FALSE -DSSG_SCIENTIFIC_LINUX_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_CENTOS_DERIVATIVES_ENABLED:BOOL=OFF -DSSG_ANSIBLE_PLAYBOOKS_PER_RULE_ENABLED:BOOL=ON |
option(SSG_PRODUCT_DEFAULT "If enabled, all default release products will be built; otherwise only explicitly enabled products will be" TRUE)
There was a problem hiding this comment.
No products seem to have been built
3 participants
Description:
Add step to build a "production" fedora build on pull requests
Rationale:
To catch issues with packaging in upstream.
Review Hints:
Check that added job ran successfully.