Conversation
blasrodri
left a comment
blasrodri
left a comment
There was a problem hiding this comment.
Looking good. Ask a review from Vlad as well
hyperspace/solana/src/lib.rs
Outdated
| .send_with_spinner_and_config(RpcSendTransactionConfig { | ||
| skip_preflight: true, | ||
| ..RpcSendTransactionConfig::default() | ||
| }).unwrap(); |
|
Why are you planning to store data in the relayer? Ideally querying the node should suffice |
I am not storing any data in the relayer. I am fetching the data from the accounts which are received from the rpc. |
|
Since i am having issues with different IBC versions, I will try to fork it and upgrade the IBC for solana and cosmos relayer. Lets see how it goes. |
|
Upgrading is quite a big task though. What’s the main issue? It should be just a handful of types that we need from new ibc. |
|
I mean we just have to upgrade the
Using the old ibc would need us to convert each type from our storage to the old ibc type. It can get messy. |
|
Well looks like @mina86 was right and upgrading seems to be a big task. So i will prolly use the old version of ibc and the new one to fetch the data from the smart contract. Would also write some conversions to convert some types from new ibc to old one. |
|
Note that with 0.48 ibc-rs got split into multiple smaller crates, so you’re probably gonna be interested only in the crates which define types. |
gotcha |
7 participants
No description provided.