ics10-grandpa-cw: decode consensus state to check for expiration#448
Open
ics10-grandpa-cw: decode consensus state to check for expiration#448
Conversation
vmarkushin
previously approved these changes
Nov 6, 2023
damiannolan
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
This looks good to me! Thank you for the super quick PR. cc. @AdityaSripal @colin-axner @crodriguezvega
Would like an ACK from one of the guys also! :)
Is it possible to add a test for this?
crodriguezvega
approved these changes
Nov 6, 2023
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Looks good to me as well. Thank you for fixing this so quickly!
Contributor
Author
Will add a test |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.