Draft
Conversation
dhruvja
requested review from
mina86 and
vmarkushin
and removed request for
mina86
For cf-solana, replace dependencies to refer to git repository rather than using path pointing outside of the repository and fix paths for DecodeError and BadMessage types. For ics10-grandpa-cw remove unnecessary as_bytes method calls which were there presumably because SUBSTITUTE_PREFIX and SUBJECT_PREFIX consts were different type at some point.
This addresses the following error present whet `std` feature is
enabled:
error: couldn't read .../debug/build/parachain-runtime-7decbbfb16bf29dd/out/wasm_binary.rs: No such file or directory (os error 2)
--> utils/parachain-node/runtime/src/lib.rs:21:1
|
21 | include!(concat!(env!("OUT_DIR"), "/wasm_binary.rs"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Replace Anchor dependency with a fork which diverges less from 0.29. The previous one had 30 commits on top of v0.29.0 tag (with 29 pulled from Anchor master). The new one is v0.29.0 with just a single commit that we need on top of it.
Previous change adding witness account to solana-ibc calls was incomplete as it didn’t add the dependency. I missed that the code wasn’t actually compiling due to many warnings polluting the build. This commit fixes all that.
* Rollup Supply Solana L1 -> L2 * Rollup Supply update period config * Default value for period in config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.