Conversation
Name was changed in new version of SQLAlchemy
He got merged, yippee!!
BigSpaceships
approved these changes
Jan 17, 2026
BigSpaceships
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested good path
- click otp
- enter correct code
- it's happy
- then it wants to remove it
Tested putting in old secret
- it just ignores it
Tested being slow and using the new otp works
Tested bad password - tells you it's wrong
Tested no password - tells you you didn't even try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
requirements.inrequirements.txtpatternmanage-totproleWhy
Test Plan
Env Vars
All RECAPTCHA_* become XCAPTCHA_*
Checklist