Start window manager as xstartup via vncserver#233
Open
darkdragon-001 wants to merge 1 commit intoConSol:masterfrom
Open
Start window manager as xstartup via vncserver#233darkdragon-001 wants to merge 1 commit intoConSol:masterfrom
darkdragon-001 wants to merge 1 commit intoConSol:masterfrom
Conversation
Member
|
what's the reason for this change? |
Contributor
Author
I updated the description (first comment). |
darkdragon-001
force-pushed
the
xstartup
branch
2 times, most recently
from
386b80f to
185e793
Compare
darkdragon-001
force-pushed
the
xstartup
branch
from
185e793 to
ae48089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be a more common pattern and should simplify life-cycle management. For example the VNC server will notice when there is an issue with the window manager and can potentially (re-)act accordingly. As this is a more common setup, it is also easier to understand for other people reading the code. I also checked that stdout/stderr of
wm_startup.shappears in~/.vnc/*.log.