chore(release): pin release-please baseline to the v0.29.2 commit#197
Merged
Conversation
release-please lost its last-release baseline after the failed 0.29.1 release was manually deleted: with the 0.29.1 GitHub release gone (its tag still present, but no release), release-please walked back to ~v0.27.1 and opened a release PR (#196) proposing 0.30.0 that re-lists 168 already-shipped commits and re-declares breaking changes released back in v0.28.0. Pin last-release-sha to the v0.29.2 release commit (7a53779) so release-please only considers commits after 0.29.2. main is currently exactly at that commit (0 commits after), so on the next run release-please will find nothing to release and close/empty #196. Future releases then bump correctly from 0.29.2. Non-bumping (chore) so this change does not itself trigger a release. The pin can be removed after the next clean release once the tag chain is trusted again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesRelease Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
release-please PR #196 proposes a bogus 0.30.0 that re-lists 168 already-shipped commits and re-declares breaking changes that released back in v0.28.0. It is fresh (created right after 0.29.2, Release Please job succeeded), so this is live misbehaviour, not a stale PR.
Root cause: the failed 0.29.1 release was manually deleted. Its GitHub release is gone (tag still present, no release), which broke release-please's last-release tracking — it walked back to ~v0.27.1 as its baseline.
Meanwhile
mainsits exactly on the v0.29.2 tag with 0 commits after it, and v0.29.2 itself is a fully-signed, verified release (image + chart signatures, SLSA provenance, SPDX SBOM all check out). So there is genuinely nothing to release right now.Fix
Pin
last-release-shato the v0.29.2 release commit (7a53779c6a8da0dbff72940011c34396a85530cc) so release-please only considers commits after 0.29.2.main), it will find no releasable commits and close/empty chore(main): release gitops-reverser 0.30.0 #196.feat→ 0.30.0,fix/perf→ 0.29.3) with only real new commits in the changelog.chore(release):— non-bumping, so it does not itself trigger a release.Do not merge #196
Merging it would tag
0.30.0on a commit identical to 0.29.2 and re-announce already-shipped breaking changes. Merge this PR instead, confirm #196 auto-closes.Follow-up (separate, destructive — not in this PR)
The failed 0.29.1 also left orphans to clean up: the stray
gitops-reverser-v0.29.1git tag, and unsigned partial:0.29.1artifacts in GHCR (image + chart).🤖 Generated with Claude Code
Summary by CodeRabbit