chore(deps): types 1.49.0, Migrate golden handoff from the package - #410
Conversation
The handoff golden now comes from MIGRATION_HANDOFF_GOLDEN in @contentrain/types, so the fixture copy is deleted. The handoff summary reads plan_hash and order_id when the document carries them, and the sync logs them so a stale handoff left by an earlier delivery can be traced. Older documents without them stay valid: unknown, never stale.
# Conflicts: # package.json # pnpm-lock.yaml
|
REVISE on ccecf0c (small). 1. The new ids are read from the customer's repo without a shape check. The handoff comes from a file in the customer's repository. 2. The new test asserts conditionally. Checked and fine: lockfile diff is only types 1.47.0 to 1.49.0 and |
Both stamps come from the customer's repository. Only 16 hex chars for plan_hash and ord_ plus 24 hex chars for order_id are read, the same shapes Migrate's validateHandoff accepts. Anything else (a non-string, a value with a newline) is unknown and never reaches the summary or the log. The golden test now asserts the stamps unconditionally.
|
ONAY on e3c12c4.
|
What
@contentrain/types1.47.0 → 1.49.0.MIGRATION_HANDOFF_GOLDENfrom the package; the copied fixturetests/fixtures/migrate-handoff-golden.jsonis deleted, so producer and consumer test the same document.plan_hashandorder_idwhen the document carries them (older documents without them stay valid: unknown, never stale), and the sync logs both so a stale handoff left by an earlier delivery can be traced. Comparing against the expected order is separate work after the E2E.Verification
pnpm typecheckclean; unit + integration suites: 2523 passed, 1 skipped.