Repository navigation
chore(deps): consolidate desktop and CodeQL updates - #210
Merged
Merged
Conversation
Signed-off-by: John Siracusa <siracusa5@users.noreply.github.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the routine desktop and CodeQL updates from Dependabot PRs #206, #207, and #208, now closed as superseded. There are no open Dependabot security alerts, and fresh full-tree npm audits remain clean in all three apps.
Changes
Affected area
Desktop runtime, updater, and packaging dependencies are updated. PR #209 handles future Dependabot grouping/cooldown configuration separately.
Validation
Local checks used Node 22.23.4; GUI checks used temporary app profiles. The local Keychain authorization block was resolved by the user, then the unchanged runtime tests were rerun.
npm test: all 76 suites pass.npm test: all 186 tests pass, including engine lifecycle, quit persistence, and window lifecycle.Existing optional UI-smoke limitation
The additional
smoke:uicheck fails when it snapshots the lazy Settings view before it leaves its loading fallback. Static comparison with unchangedmainalso confirms stale assertions: five navigation entries are expected where the current sidebar defines six, and the Overview check refers to sections the current UI no longer renders. This optional harness needs a separate readiness/expectation update; it is not claimed as passing. The lifecycle, IPC/relaunch, navigation, sandbox/token, and isolation checks above pass.Compatibility
Electron 45's removed sandboxed-preload Node globals are not used by this app's preload. Its synchronous safeStorage APIs still work in 45 but are deprecated; upgrading to 46 requires a separate API migration. These dependency changes reach installed users through the next app release.
Sign-off