fix(review): Rust 1.97.1로 오프라인 커버리지 복구#592
Open
seonghobae wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores offline Rust coverage compatibility for Rust 2024 manifests by updating the trusted OpenCode coverage tool image to a digest-pinned official Rust 1.97.1 base, removing reliance on stale distro cargo/rustc, and hardening the toolchain exposure inside the no-network sandbox. It also updates model-candidate ordering and tightens central fallback timeouts, with contract tests updated to lock the new behavior.
Changes:
- Switch trusted coverage-tool Docker base image to digest-pinned
rust:1.97.1and install/verifyllvm-tools-preview; remove distrocargo/rustc. - Harden Rust toolchain directories and expose
RUSTUP_HOME+/usr/local/cargo/binin sandbox runtime, recording Rust/Cargo/cargo-llvm-cov versions as evidence. - Reorder OpenCode model candidates and reduce central review-process fallback timeout/budget; update contract assertions accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_opencode_agent_contract.py |
Updates contract assertions to pin the new Rust toolchain image/digest, sandbox env exposure, version evidence, and updated model/fallback settings. |
.github/workflows/opencode-review.yml |
Updates the trusted offline coverage tool image build to Rust 1.97.1 + llvm-tools, tightens toolchain permissions, adjusts sandbox PATH/RUSTUP_HOME, and revises model ordering + fallback time budgets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #591
원인
ContextualWisdomLab/codec-carver#250current-head OpenCode 실행 https://github.com/ContextualWisdomLab/.github/actions/runs/29676953842 에서 Python 561개 테스트·라인 커버리지·문서화는 모두 100%였지만, 중앙 coverage 이미지의 Ubuntu Cargo 1.75.0이 Rust 2024 매니페스트를 파싱하지 못했습니다.정확한 실패는
feature edition2024 is required이며 애플리케이션 테스트가 시작되기 전의 중앙 도구체인 결함입니다.변경
cargo/rustc설치를 제거합니다.llvm-tools-preview를 설치하고 버전을 검증합니다.RUSTUP_HOME과 Rust proxy 경로만 읽기 전용으로 노출합니다.PR 코드는 기존과 동일하게
docker run --network=none,--cap-drop ALL, UID/GID 65532에서 실행되며 Docker 소켓과 자격 증명은 노출되지 않습니다.검증
python3 -m pytest -q: 634 passedcoverage run -m pytest -q tests && coverage report --fail-under=100: 5,527 statements, 100%python3 -m interrogate .: 100%STRIX_TEST_CASE_FILTER=success bash scripts/ci/test_strix_quick_gate.sh: passedgit diff --check: passed전체 Ruff format 검사는 main에 이미 존재하는 44개 파일의 포맷 차이를 보고하므로 이번 범위에서 기계적으로 변경하지 않았습니다. 변경한 Python 파일의 Ruff check는 통과했습니다.
공유 로컬 Podman 저장소 공간 부족으로 공식 Rust 이미지 풀은 완료하지 못했습니다. 기존 사용자 이미지는 정리하지 않았으며, exact-head 호스티드 coverage 이미지 빌드를 통합 증거로 사용합니다.
Unblocks: ContextualWisdomLab/codec-carver#250