Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] λŒ€ν™”ν˜• ν”„λ‘¬ν”„νŠΈμ˜ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œ 취약점 방지 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] λŒ€ν™”ν˜• ν”„λ‘¬ν”„νŠΈμ˜ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œ 취약점 방지 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
**Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
**Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
**Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
## 2024-05-24 - [CRITICAL] Prevent Integer Overflow Coercion in Interactive Prompts
**Vulnerability:** Interactive `readline()` prompt validations were using unbounded digit classes (`^[0-9]+$`) to match single-digit numeric inputs (e.g., "1" or "2").
**Learning:** This approach enables integer overflow coercion vulnerabilities. When an excessively large numeric string is passed, it matches the regex but evaluates to `NA` when coerced via `as.integer()`. This allows unexpected values to bypass the validation and can cause subsequent process crashes (Denial of Service) when passed to downstream logic expecting a valid integer.
**Prevention:** Strictly match against the exact expected values (e.g., `^[12]$`) rather than unbounded digit classes when validating interactive `readline()` numeric inputs.
6 changes: 3 additions & 3 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ autoFIPC <-
}
for (attempt in seq_len(3)) {
n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -171,7 +171,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -390,7 +390,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down
Loading