Skip to content

🎨 Palette: [UX improvement] 접을 수 μžˆλŠ” μ˜μ—­ μ ‘κ·Όμ„± κ°•ν™”#275

Open
seonghobae wants to merge 1 commit into
developmentalfrom
palette/overview-stats-accessibility-1249246358151176680
Open

🎨 Palette: [UX improvement] 접을 수 μžˆλŠ” μ˜μ—­ μ ‘κ·Όμ„± κ°•ν™”#275
seonghobae wants to merge 1 commit into
developmentalfrom
palette/overview-stats-accessibility-1249246358151176680

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What

OverviewStats μ»΄ν¬λ„ŒνŠΈ ν•˜λ‹¨μ˜ "What do these numbers mean?" 접이식 μ„€λͺ… μ˜μ—­μ˜ 접근성을 κ°•ν™”ν–ˆμŠ΅λ‹ˆλ‹€. React의 useId 훅을 λ„μž…ν•΄ ν† κΈ€ λ²„νŠΌκ³Ό μ„€λͺ… 컨텐츠 μ˜μ—­ 간에 고유 IDλ₯Ό ν†΅ν•œ ARIA μ—°κ²°(aria-controls, aria-labelledby)을 κ΅¬μΆ•ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

이전 κ΅¬ν˜„μ—μ„œλŠ” λ²„νŠΌμ˜ aria-controls와 λ‚΄μš© μ˜μ—­μ˜ idκ°€ 정적 λ¬Έμžμ—΄λ‘œ ν•˜λ“œμ½”λ”© λ˜μ–΄ μžˆμ–΄ ν•œ νŽ˜μ΄μ§€μ— 이 μ»΄ν¬λ„ŒνŠΈκ°€ μ—¬λŸ¬ 번 쓰일 경우 ID 좩돌 λ¬Έμ œκ°€ λ°œμƒν•  수 μžˆμ—ˆκ³ , λ‚΄μš© μ˜μ—­μ— λͺ…ν™•ν•œ role 속성이 μ—†μ–΄ 보쑰 기술 μ‚¬μš©μžκ°€ μ ‘νžŒ λ‚΄μš©μ΄ μ–΄λ–»κ²Œ μ—°κ΄€λ˜λŠ”μ§€ νŒŒμ•…ν•˜κΈ° μ–΄λ €μ› μŠ΅λ‹ˆλ‹€. 이λ₯Ό W3C μ ‘κ·Όμ„± ꢌμž₯ νŒ¨ν„΄μ— λ§žμΆ”μ–΄ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

μ‹œκ°μ  λ³€κ²½ 사항은 μ—†μœΌλ©° DOM ꡬ쑰의 μ ‘κ·Όμ„± μ†μ„±λ§Œ μΆ”κ°€/μˆ˜μ •λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

β™Ώ Accessibility

  • λ²„νŠΌ(<button>)에 동적 id λΆ€μ—¬, λ‚΄μš©μ„ μ œμ–΄ν•¨μ„ λͺ…μ‹œ(aria-controls).
  • λ‚΄μš© μ˜μ—­(<div>)에 동적 id λΆ€μ—¬ 및 λžœλ“œλ§ˆν¬ μ—­ν• (role="region") μ„€μ •.
  • λ‚΄μš© μ˜μ—­μ— 이 μ˜μ—­μ„ μ„€λͺ…ν•΄μ£ΌλŠ” λ²„νŠΌ μ°Έμ‘°(aria-labelledby) μΆ”κ°€.

PR created automatically by Jules for task 1249246358151176680 started by @seonghobae

- `OverviewStats` μ»΄ν¬λ„ŒνŠΈμ˜ μ„€λͺ… ν† κΈ€ μ˜μ—­μ— `useId`λ₯Ό μ μš©ν•˜μ—¬ `aria-controls`와 `aria-labelledby`λ₯Ό λ™μ μœΌλ‘œ λ§€ν•‘ν–ˆμŠ΅λ‹ˆλ‹€.
- ν† κΈ€λ˜λŠ” 컨텐츠 μ˜μ—­μ— `role="region"`을 λͺ…μ‹œν•˜μ—¬ 슀크린 리더 ν™˜κ²½μ˜ 접근성을 ν–₯μƒμ‹œμΌ°μŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant