Skip to content

Conversation

@shroffk
Copy link
Member

@shroffk shroffk commented Jan 6, 2026

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@shroffk
Copy link
Member Author

shroffk commented Jan 9, 2026

context menu Screenshot 2026-01-05 131329

@shroffk shroffk requested a review from georgweiss January 9, 2026 16:12
@shroffk shroffk mentioned this pull request Jan 9, 2026
6 tasks
@shroffk shroffk requested a review from kasemir January 9, 2026 20:11
@kasemir
Copy link
Collaborator

kasemir commented Jan 9, 2026

Is there a way to suppress the context menu? Maybe that's already in the contribution support, I forgot. Or somehow tie this to authorization for the alarm configuration?

In any case, for our setup I don't want to have "Add to alarm tree" in every PV context menu.
Adding an alarm requires some thought. Authorization is limited to those who check if the PV is useful, what the guidance should be, suitable related display etc.

@shroffk
Copy link
Member Author

shroffk commented Jan 9, 2026

I can add a preference for this, the framework already exists in the ContextMenuAction interface

While I agree that alarm configurations should be made thoughtfully... this context menu is just making the current "add component" action from the alarm tree, which does allow specifying multiple PVs, a little bit easier to access.

@shroffk
Copy link
Member Author

shroffk commented Jan 9, 2026

by simplifying this workflow I am hoping to avoid other programmatic/scripted solutions which have been necessary when adding a large number of PV's...a workflow which is even future away from the thoughtful user actions :)

The authorization part is a valid issue which might need a bit more thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants