Skip to content

Add alarm_table_font_size - #3961

Merged
shroffk merged 1 commit into
ControlSystemStudio:masterfrom
LordIdra:alarm-table-font-size-setting
Oct 21, 2026
Merged

shroffk merged 1 commit into
ControlSystemStudio:masterfrom
LordIdra:alarm-table-font-size-setting

Conversation

@LordIdra

@LordIdra LordIdra commented Oct 15, 2026 •

Copy link
Copy Markdown

Adds a alarm_table_font_size to settings.ini which does what you think it does:

image

e.g.

org.phoebus.applications.alarm/alarm_table_font_size=25

Set to 12px by default

The icon textures are only 32x32 which means they can look blurry on larger font sizes. But fixing this seems out of scope for this PR (I can just open an issue to add higher-res icons if needed)

Closes #3943

Checklist

  • Testing: Tested alarm table with different font sizes, including with resetting the memento
  • Documentation: Auto-generated on preference listing page

Also can someone please give me a pointer on how to do the '- [ ] Added an entry when adding a new feature' checklist item? docs/source/changelog.rst seems very outdated

@sonarqubecloud

Copy link
Copy Markdown

@roycpro

roycpro commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

I have tested with alarm_table_font_size= 5, 20 and also without defining the property.
All these use cases worked.

@shroffk

shroffk commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Should we have the check that if the set font size is larger than the height then either it

  1. ignores the setting
  2. uses the maximum size that can fit

@roycpro

roycpro commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Also, shouldn't we apply the scale to the column width? PV, Description, Alarm Severity...

@LordIdra

Copy link
Copy Markdown
Author

Should we have the check that if the set font size is larger than the height then either it

  1. ignores the setting
  2. uses the maximum size that can fit

Larger than what height? The cells scale with the font size so that is OK.

Also, shouldn't we apply the scale to the column width? PV, Description, Alarm Severity...

Yeah can do, though should probably call it something like 'scale' or 'zoom' rather than font size in that case?

@shroffk

shroffk commented Oct 21, 2026

Copy link
Copy Markdown
Member

Larger than what height? The cells scale with the font size so that is OK.

Yup, we discovered this when we set the size to 100 :)

Let us merge this ( since it is consistent with the area panel ) and then worry about zoom latter.

@shroffk
shroffk self-requested a review October 21, 2026 17:56
@shroffk
shroffk merged commit 49c65d9 into ControlSystemStudio:master Oct 21, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow alarm table font size to be changed independently

3 participants