Put Stop and Quit on the window, not only in the tray - #409
Merged
Conversation
… to be there Stop lived only in the tray icon, and the tray fails in two different ways, both measured rather than assumed. A bare Linux window manager has no StatusNotifierWatcher, which is what the icon is published to, so no icon is ever drawn. On Windows the icon appears on a clean boot and does not come back after Explorer restarts, because re-adding it on the `TaskbarCreated` broadcast is the application's job and nothing does it. Either way the same thing happens: closing the window hides it, the stack keeps running, and the only control that could stop it is an icon that is not on screen. Relaunching does hand the window back, but knowing that is not something to require of somebody. The three items are on the window's own menu now as well, sharing one function with the tray so that Stop cannot come to mean two things depending on where it was clicked. Verified in the running application rather than by reading the code: the menu reports Open OpenBot, Stop OpenBot, Quit.
davidmckayv
requested review from
MikeRyanDev,
guidovizoso and
tylerslaton
as code owners
September 6, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop lived only in the tray, and the tray is absent in two measured cases: a bare Linux window manager has no
StatusNotifierWatcherso the icon is never drawn, and on Windows the icon does not survive an Explorer restart because nothing re-adds it onTaskbarCreated.Closing the window hides it, so either case leaves a running stack with nothing on screen that can stop it.
The same three items are now on the window menu, sharing one handler with the tray. Checked in the running app: the menu reports
Open OpenBot, Stop OpenBot, Quit.