Repository navigation
fix(mcp): create an MCP server per HTTP request - #104
Open
asasemahmed wants to merge 1 commit into
Open
asasemahmed wants to merge 1 commit into
asasemahmed wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP entry point creates one
McpServerat module load and callsserver.connect()with a new transport on every request.connect()replaces the server's current transport. So when two requests overlap, a response can be written to the other request's transport, and the first caller never gets an answer.Repro: send a
tools/callwhose body arrives slowly. While it is still arriving, send a second request. The second request gets 200, and the first one hangs.The transport is created without a
sessionIdGenerator, so the server already runs in stateless mode: nomcp-session-idis ever returned, and thesessionsmap is never filled. This change follows the SDK's stateless pattern of a new server and transport per request, and removes the unused map.To make the route testable, the Hono app moved into
src/app.ts(createApp()).src/index.tsnow only reads the env vars and starts the server.Tests:
tests/app.test.tsstalls request 1's body, completes request 2, then releases request 1 and asserts that each gets its own result. On main, request 1 never answers.