Repository navigation
docs(mcp): drop allow-same-origin from the iframe example - #110
Open
asasemahmed wants to merge 1 commit into
Open
asasemahmed wants to merge 1 commit into
asasemahmed wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assemble_documentexample in the MCP README suggests rendering the result withsandbox="allow-scripts allow-same-origin". Asrcdociframe inherits the embedding page's origin, so with both flags generated scripts can reachparent.documentand the host'slocalStorage, and can even remove their own sandbox. The web app already avoids this; see #3 and the sandbox notes in CLAUDE.md.The bridge only uses
postMessage(..., "*"), soallow-scriptsalone is enough. The example now uses it, with a short note on why.