Skip to content

fix(app): use the latest streamed preview when the sandbox becomes ready #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rudycelekli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(app): use the latest streamed preview when the sandbox becomes ready #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...omponents/generative-ui/open-generative-ui/__tests__/open-generative-ui-renderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,4 +647,17 @@ describe("OpenGenUIActivityRenderer", () => {
});
expect(parsed.success).toBe(true);
});

it("uses the latest streamed preview when sandbox readiness is delayed", async () => {
const base = { cssComplete: true, htmlComplete: false, generating: true };
const { rerender } = renderRenderer({ ...base, css: "p{color:red}", html: ["<p>old</p>"] });
await flushImport();
rerender(rendererElement({ ...base, css: "p{color:blue}", html: ["<p>latest</p>"] }));
await act(async () => { await new Promise((r) => setTimeout(r, THROTTLE_MS + 50)); });
await resolveSandboxReady();
expect(runCallsContaining("Idiomorph.morph").at(-1)?.[0]).toContain("latest");
expect(runCallsContaining("document.head.innerHTML").at(-1)?.[0]).toContain("color:blue");
expect(mockCreate).toHaveBeenCalledTimes(1);
});

});
11 changes: 8 additions & 3 deletions apps/app/src/components/generative-ui/open-generative-ui/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ const OpenGenUIActivityRendererInner = React.memo(
const previewBody = partialHtml ? processPartialHtml(partialHtml) : undefined;
const previewStyles = partialHtml ? extractCompleteStyles(partialHtml) : "";
const hasPreview = cssReady && !!previewBody?.trim();
const latestPreviewRef = useRef({ css, previewStyles, previewBody });
useEffect(() => {
latestPreviewRef.current = { css, previewStyles, previewBody };
}, [css, previewStyles, previewBody]);
const hasVisibleSandbox = !!fullHtml || hasPreview;

const containerRef = useRef<HTMLDivElement>(null);
Expand Down Expand Up @@ -210,15 +214,16 @@ const OpenGenUIActivityRendererInner = React.memo(
sandbox.promise.then(() => {
if (cancelled) return;
previewReadyRef.current = true;
const latest = latestPreviewRef.current;

sandbox.run(IDIOMORPH_JS);
sandbox.run(
`document.head.innerHTML = ${JSON.stringify(
buildPreviewHeadContent(css, previewStyles)
buildPreviewHeadContent(latest.css, latest.previewStyles)
)}`
);
if (previewBody) {
sandbox.run(buildPreviewBodyMorph(previewBody));
if (latest.previewBody) {
sandbox.run(buildPreviewBodyMorph(latest.previewBody));
}
});
})
Expand Down