Skip to content

fix(app): clamp the initial activity height before rendering the iframe container #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rudycelekli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(app): clamp the initial activity height before rendering the iframe container #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...omponents/generative-ui/open-generative-ui/__tests__/open-generative-ui-renderer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,4 +647,11 @@ describe("OpenGenUIActivityRenderer", () => {
});
expect(parsed.success).toBe(true);
});

it.each([[-100, "50px"], [0, "50px"], [50000, "4000px"], [300.2, "301px"], [NaN, "200px"], [Infinity, "200px"]])("bounds invalid initial activity height %s", async (initialHeight, expected) => {
const { container } = renderRenderer({ initialHeight, generating: true });
await flushImport();
expect(container.querySelector<HTMLElement>("div[style]")!.style.height).toBe(expected);
});

});
2 changes: 1 addition & 1 deletion apps/app/src/components/generative-ui/open-generative-ui/renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ function styleIframe(iframe: HTMLIFrameElement) {

const OpenGenUIActivityRendererInner = React.memo(
function OpenGenUIActivityRendererInner({ content }: InnerProps) {
const initialHeight = content.initialHeight ?? 200;
const initialHeight = clampReportedHeight(content.initialHeight) ?? 200;
const [autoHeight, setAutoHeight] = useState<number | null>(null);
const sandboxFunctions = useSandboxFunctions();

Expand Down