Add aruco detector parameter file#228
Open
sfalexrog wants to merge 2 commits intoCopterExpress:masterfrom
Open
Add aruco detector parameter file#228sfalexrog wants to merge 2 commits intoCopterExpress:masterfrom
sfalexrog wants to merge 2 commits intoCopterExpress:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the current master has a fully configurable aruco detector, I believe it would be nice to have an example of using a .yaml file to configure detector parameters at launch time. This may be considered more as a piece of documentation than something that is necessary.
I am hesitant to use the same approach in
clover'saruco.launch, though.Another thing that would be nice is to have better default parameters (as tested by @goldarte). At the very least we should set
minMarkerPerimeterRateto a sensible value to avoid crashes.