feat: batch validation, scheduled E2E, contract fuzz, and wallet integration tests#236
Merged
Merged
Conversation
|
@miss-yusrah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #82
closes #98
closes #200
closes #201
PR description
Summary
This PR adds backend batch validation, end-to-end scheduled notification tests, Soroban contract fuzz tests, and wallet integration tests — with CI updates for fuzz coverage and wallet test reports.
Task 1 — [Backend] Notification Batch Validation Service
What changed
BatchValidatorwith structured errors (code,field,index,message)BatchValidationServiceas the service layer withvalidate()andrejectIfInvalid()POST /api/notifications/validate-batchinto the events serverNotificationSchedulerbefore batch processing — invalid batches are rejected with actionable errors; valid batches continuebatch-validator.test.tsand API tests inevents-server.test.tsAcceptance criteria
Test plan
cd listener && npm testcd dashboard && npm test && npm run test:walletcd contract && cargo test --workspace && cargo test fuzz_bash scripts/run-fuzz-coverage.shPOST /api/notifications/validate-batchwith valid and invalid payloadsfuzz-coverage-report,wallet-integration-reportNotes
notification-scheduler-refactoredstats timing) were not modified.DiscordNotificationServiceto avoid Stellar XDR JSON round-trip issues in SQLite payloads.