chore: add missing project infrastructure (CI, templates, .gitignore)#1
chore: add missing project infrastructure (CI, templates, .gitignore)#1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5220350c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cache: "pnpm" | ||
| cache-dependency-path: server/pnpm-lock.yaml | ||
| - run: cd server && pnpm install --frozen-lockfile | ||
| - run: cd server/packages/database && pnpm prisma generate |
There was a problem hiding this comment.
Provide DATABASE_URL before Prisma client generation
pnpm prisma generate is run without DATABASE_URL in the environment, but server/packages/database/prisma.config.ts calls env("DATABASE_URL") during Prisma config loading. That makes the typecheck job fail before pnpm build starts (and the same pattern appears in test before pnpm test), so this CI workflow can fail on valid changes.
Useful? React with 👍 / 👎.
Summary
.gitignore— covers OS files (.DS_Store), IDE configs (.idea/,.vscode/), Node build artifacts (dist/,node_modules/), and environment files (.env*).github/workflows/ci.yml) — three jobs: lint/format, typecheck/build, and unit tests with PostgreSQL + Redis service containersbug_report.ymlandfeature_request.ymlwith structured forms for component selection and reproduction steps.github/PULL_REQUEST_TEMPLATE.mdwith change type checklist and conventional commit reminderContext
Project review (ISS-115) identified these as the highest-priority gaps:
.gitignore— OS/IDE files not globally ignoredTest plan
mainpnpm format-and-lintin theserver/monorepopnpm build(includes Prisma generate)pnpm testwith PostgreSQL + Redis service containers🤖 Generated via BusyDog Desktop collaboration task