Skip to content

fix(cli): require workspace config to be a file#317

Open
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-workspace-show-config-file-check
Open

fix(cli): require workspace config to be a file#317
OnlyYu1996 wants to merge 1 commit into
CortexLM:mainfrom
OnlyYu1996:fix-workspace-show-config-file-check

Conversation

@OnlyYu1996
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53136.

workspace show now treats .cortex/config.toml as present only when it is a regular file. A directory at that path is reported as not configured and settings loading returns None, avoiding the previous has_cortex_config: true / settings: null false positive.

Validation:

  • cargo +1.90.0 fmt --package cortex-cli --check
  • isolated rustc +1.90.0 --test harness covering config file vs config directory detection
  • git diff --check

Note: full cargo +1.90.0 test -p cortex-cli ... is blocked on this Windows machine by the existing workspace aws-lc-sys MSVC build failure before cortex-cli tests run.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] workspace show treats .cortex/config.toml directory as valid "present" config

1 participant