Skip to content

Restrict GitHub workflow uninstall detection#388

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:restrict-github-uninstall-generated-workflows
Open

Restrict GitHub workflow uninstall detection#388
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:restrict-github-uninstall-generated-workflows

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Require the cortex github install generator marker before github uninstall treats a workflow file as Cortex-owned.
  • Prevent unrelated workflow files that merely mention cortex from being removed.
  • Add binary integration coverage for rejecting an unrelated workflow and still removing a generated Cortex workflow.

Fixes PlatformNetwork/bounty-challenge#46726.

Validation

  • cargo test -p cortex-cli --test github_uninstall_workflow --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex github uninstall deletes unrelated workflow files whose contents merely mention cortex

1 participant