Skip to content

Resolve dotted config get keys#390

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:config-get-dotted-keys
Open

Resolve dotted config get keys#390
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:config-get-dotted-keys

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Resolve cortex config get keys by exact root key first, then by dot-separated TOML table traversal.
  • Preserve existing behavior for literal root keys while allowing nested values like model.default.
  • Add a CLI regression test for reading [model] default = ... via config get model.default.

Fixes PlatformNetwork/bounty-challenge#46835.

Validation

  • cargo test -p cortex-cli --test config_get --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] Cortex CLI: cortex config get does not resolve nested / dotted keys

1 participant