Skip to content

Align GitHub workflow detection#394

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:align-github-workflow-detection
Open

Align GitHub workflow detection#394
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:align-github-workflow-detection

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Make github status, github install, and github uninstall identify Cortex-owned workflows with the existing cortex github install generator marker.
  • Prevent github install from silently creating Cortex.yml when another generated Cortex workflow already exists under a different filename.
  • Let github uninstall remove the same generated workflow that github status reports, even when it is named release.yml.
  • Add a CLI regression covering status, duplicate install rejection, and uninstall against a generated release.yml.

Fixes PlatformNetwork/bounty-challenge#53318.
Also addresses PlatformNetwork/bounty-challenge#53317.

Validation

  • cargo test -p cortex-cli --test github_workflow_detection --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex github install creates a new Cortex.yml without detecting or warning about existing Cortex-related workflows

1 participant