Skip to content

Respect model option for agent create#398

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:agent-create-model-option
Open

Respect model option for agent create#398
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:agent-create-model-option

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Make agent create --model an explicit optional override instead of an always-present default that only generation used.
  • Write the requested model into normal created agent frontmatter in non-interactive mode and use it as the interactive model prompt default.
  • Keep gpt-4o as the default generation model when --generate is used without --model.
  • Add binary CLI coverage for agent create --model and for preserving no model override when omitted.

Fixes PlatformNetwork/bounty-challenge#52744.

Validation

  • cargo test -p cortex-cli --test agent_create_model --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check
  • git diff --cached --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex agent create --model is ignored unless --generate is also used

1 participant