Skip to content

Filter logs paths to log files#399

Open
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-paths-filter-log-files
Open

Filter logs paths to log files#399
GreyforgeLabs wants to merge 1 commit into
CortexLM:mainfrom
GreyforgeLabs:logs-paths-filter-log-files

Conversation

@GreyforgeLabs
Copy link
Copy Markdown

Summary

  • Share log-file detection between normal log selection and logs --paths.
  • Filter logs --paths output to .log and .txt files instead of every regular file.
  • Add CLI regression coverage for ignoring non-log files.

Fixes PlatformNetwork/bounty-challenge#52680.

Validation

  • cargo test -p cortex-cli --test logs_paths --no-default-features --features cortex-tui -- --nocapture
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo fmt --package cortex-cli --check
  • git diff --check
  • git diff --cached --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex logs --paths lists all files in the logs directory, not just log files

1 participant