Repository navigation
fix: coalesce remote Chat catalog reads for sharing - #72
Draft
Mathis (echobt) wants to merge 1 commit into
Draft
Mathis (echobt) wants to merge 1 commit into
Mathis (echobt) wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
Found 39 test failures on Blacksmith runners: Failures
...and 29 more test failures. View all on Blacksmith
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Coalesce remote Chat and signed-in Chat feature catalog loads through
remoteChatModels(). All consumers useapi.remoteSessions.models(), which populates the Chat core catalog. Code catalog responses no longer share the same key with Chat responses. Concurrent core reads invalidate each other; sharing the in-flight request prevents that race while later calls still refresh.Follow-up to merged #71 (
e424012c), based on current mainfdd83ec. The uncommitted broader D03 recovery in/root/cortex-dev/worktrees/ux-d03remains untouched and is not included or claimed integrated here.How to try it
Build/start, select a self-hosted connection, sign in with a configured text-only model. Open
#/home, then#/share. Select a saved conversation, create a link, revoke it. Share remains functional without tool/image capabilities.Honest states
Existing loading/error and epoch/route guards remain intact. No indefinitely cached catalog is introduced. This bounded PR does not claim full DSK-07 discovery recovery or installed macOS/Windows/backend assembly. M09/M10 still require M11.
Verification
bun run lint,bun run typecheck,bun run audit:i18n, productionbun run build: passed. Complete unit suite: 65 files, 521 passed, one existing conditional skip. Catalog regression proves one shared pending request plus a fresh request after settlement.Real built Electron Share test: two cases passed, link create/list/revoke through the actual main/IPC transport and local HTTP producer fixture. Screenshots inspected in light/dark, 1440x900 and 960x640. Existing Chat tools: three observed passes. Broader existing remote Chat regression fails on the merged registry/legacy route defect; no assertion was changed. Historical #71 has 13 failed native CI jobs, independently queried.
Evidence:
/root/omo-herdr-wt/hermes-docs-qa-docs-attempt2/.omo/evidence/D03/D03-share-catalog-manual-qa.mdand/root/cortex-dev/ux-implementation/D03/share-catalog-current.Risk and rollback
Renderer catalog ownership only. Revert this follow-up to restore independent reads. Broader recovery changes, native integration and required CI completion remain separate and unverified.
Attestation
Tick a box only if it is true. If a line does not apply, leave it unticked and say
why on the line. Do not delete this block.
AGENTS.mdand the relevant files in.rules/before writing code, and this change follows them..rules/02-errors.md).rules/03-responsive.md).rules/01-security.md)AGENTS.mdis updated if this change touches product surfaces, engine routes, environment/configuration, or error copy; other affected docs underdocs/are updated too. (.rules/05-documentation.md) Nested Chat AGENTS.md and docs/providers.md updated. Exact root AGENTS.md patch supplied to parent; not yet applied.