Skip to content

fix(probe): follow HF redirect in ingress measurement - #15

Merged
Mathis (echobt) merged 1 commit into
mainfrom
fix/probe-hf-redirect
Oct 17, 2026
Merged

Mathis (echobt) merged 1 commit into
mainfrom
fix/probe-hf-redirect

Conversation

@echobt

@echobt Mathis (echobt) commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

HF resolve URLs answer 302 to the CDN; curl without -L downloaded the 1040-byte redirect body, so every probe host measured ingress=0 Mbit/s and was rejected as slow. Verified from the controller: without -L: 302, 1040 bytes; with -L: 206, full range.

Summary by CodeRabbit

  • Bug Fixes
    • The Hugging Face ingress probe now follows redirects when checking ranged downloads.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ecf73a6f-3baa-4d3a-a58f-b3ff5862d345
📥 Commits

Reviewing files that changed from the base of the PR and between 1df4832 and d6fc70b.

📒 Files selected for processing: 1
  • scripts/ops/probe_and_launch.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The ranged Hugging Face ingress probe now uses curl -L to follow redirects. The range, timeout, and download measurement remain unchanged.

Changes: Ingress probe

Layer / File(s) Summary
Follow redirects
scripts/ops/probe_and_launch.py
The ranged curl request now follows redirects with -L. The range, timeout, and download measurement remain unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d6fc7

The probe now follows Hugging Face redirects and measures the ranged download rather than the redirect response. No actionable merge-blocking risk is established; it appears ready for normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: following Hugging Face redirects during ingress probing.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@echobt
Mathis (echobt) merged commit 1818f9e into main Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant