Skip to content

ccc-track: don't wake/label on closed or merged PRs #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Corvimia merged 1 commit into from
Feb 13, 2026
Merged

ccc-track: don't wake/label on closed or merged PRs #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions .github/workflows/ccc-track.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,27 @@ jobs:
contentBody = prLike.body || '';
}

const mentionDetected = mentionRe.test(contentBody);
const mentionDetectedRaw = mentionRe.test(contentBody);

// If this is a PR, suppress BOTH labeling + waking once the PR is closed or merged.
async function fetchPrInfo() {
if (threadType !== 'pr') return null;

if (prLike) {
return {
state: prLike.state,
merged: Boolean(prLike.merged),
};
}

// issue_comment payload for PRs comes through as `issue` with `issue.pull_request`.
// Fetch live PR state via API.
const res = await github.rest.pulls.get({ owner, repo, pull_number: number });
return {
state: res.data.state,
merged: Boolean(res.data.merged),
};
}

// Helper: fetch live labels from GitHub (don’t trust payload)
async function fetchLabels() {
Expand All @@ -113,7 +133,13 @@ jobs:
return labels;
}

// Apply label on mention (idempotent)
const prInfo = await fetchPrInfo();
const prIsOpen = (threadType !== 'pr') || (prInfo && prInfo.state === 'open' && prInfo.merged !== true);
const suppressedNonOpenPr = (threadType === 'pr') && !prIsOpen;

const mentionDetected = suppressedNonOpenPr ? false : mentionDetectedRaw;

// Apply label on mention (idempotent) — but never on closed/merged PRs.
if (mentionDetected) {
await github.rest.issues.addLabels({
owner,
Expand All @@ -126,8 +152,9 @@ jobs:
const labels = await fetchLabels();
const tracked = labels.map(l => String(l).toLowerCase()).includes(trackLabel.toLowerCase());

// Wake on original mention OR on any activity for tracked threads
const shouldWake = mentionDetected || tracked;
// Wake on original mention OR on any activity for tracked threads.
// For PRs: never wake if the PR is closed or merged.
const shouldWake = suppressedNonOpenPr ? false : (mentionDetected || tracked);

const payload = {
source: 'github',
Expand Down Expand Up @@ -164,8 +191,12 @@ jobs:
signals: {
mention_user: `@${mentionUser}`,
mention_detected: mentionDetected,
mention_detected_raw: mentionDetectedRaw,
tracked,
should_wake: shouldWake,
pr_state: prInfo ? prInfo.state : null,
pr_merged: prInfo ? prInfo.merged : null,
suppressed_non_open_pr: suppressedNonOpenPr,
},
};

Expand Down